Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ml): introduce support of onnxruntime-rocm for AMD GPU #11063

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
mark mutex as mutable
mertalev committed Dec 29, 2024
commit 5940861649f4d53f66912d97dab77fa24ec48ff5
6 changes: 3 additions & 3 deletions machine-learning/0001-guard-algo-benchmark-results.patch
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
From dbc1e115a2c3c05f676dcfeb85895ed67000a348 Mon Sep 17 00:00:00 2001
From 1f5d6323fa69ee16feab25f8e1398c1aed03ee08 Mon Sep 17 00:00:00 2001
From: mertalev <[email protected]>
Date: Sun, 29 Dec 2024 14:07:51 -0500
Subject: [PATCH] guard algo benchmark results
@@ -8,7 +8,7 @@ Subject: [PATCH] guard algo benchmark results
1 file changed, 6 insertions(+)

diff --git a/onnxruntime/core/providers/rocm/nn/conv.h b/onnxruntime/core/providers/rocm/nn/conv.h
index bc9846203e..b1cd2a449d 100644
index bc9846203e..0086e064f1 100644
--- a/onnxruntime/core/providers/rocm/nn/conv.h
+++ b/onnxruntime/core/providers/rocm/nn/conv.h
@@ -52,6 +52,7 @@ class lru_unordered_map {
@@ -49,7 +49,7 @@ index bc9846203e..b1cd2a449d 100644
size_t max_size_;
std::unordered_map<Key, value_type, Hash, KeyEqual, MapAllocator> items_;
list_type lru_list_;
+ std::mutex mutex_;
+ mutable std::mutex mutex_;
};

// cached miopen descriptors

Unchanged files with check annotations Beta

./cmake-3.27.3-linux-x86_64.sh --skip-license --prefix=/code/cmake-3.27.3-linux-x86_64 && \
rm cmake-3.27.3-linux-x86_64.sh
ENV PATH /code/cmake-3.27.3-linux-x86_64/bin:${PATH}

Check warning on line 32 in machine-learning/Dockerfile

GitHub Actions / Build and Push ML (linux/amd64, rocm, -rocm)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
# Prepare onnxruntime repository & build onnxruntime
RUN git clone --single-branch --branch v1.19.2 --recursive "https://github.com/Microsoft/onnxruntime" onnxruntime