-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): show stack in album #12276
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought stacks were only supposed to show up on the main timeline for the given user. Does granting access to a primary asset on a stack (via an album) also now imply read access to every asset in the stack?
@jrasm91 I was debating this as well. Maybe it makes sense to assume that if you want to put a stack asset in an album, you would want all the stack children to go with it. I think in real-world use case, the user would typically stack similar photos together |
From my point of view (not that anyone is asking :D), if an asset is stacked, it should show up everywhere as stacked - timeline, albums, places, people. I personally stack very similar/identical pictures together, so for me the stack represents a single asset that, for one reason or another, I decided to keep multiple copies of. However, I dont want to have my albums (automatically created from folders in an external library) or timeline spammed with multiple similarly looking pictures, hence why I stack them. |
I think this would be a useful change as well. I just started using stacks and noticed they were not stacked in albums which caused me to stumble upon this PR. Permission wise, I think its fine to treat them as a single item as the stack is likely highly related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Change makes sense too IMO -- especially when it comes to bursts where I'd still want people to have access to all the photos in a burst even in an album w/o the album being sluggish to scroll through.
Out of curiosity, will it mean when I share an album, other people can see the stacked images as well? |
Fixes #12273
Show stacked asset in album and in selection view.
Also fix an issue of the timeline does not appear after adding new assets to the album