refactor: orientation #12792
Open
refactor: orientation #12792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
force-pushed
the
refactor/exif-orientation
branch
from
1a2c9a7 to
ec48359
Compare
danieldietzler
approved these changes
Sep 19, 2024
jrasm91
force-pushed
the
refactor/exif-orientation
branch
from
ec48359 to
8af7a9c
Compare
|
Might also fix #10208? |
mertalev
reviewed
Oct 24, 2024
| @@ -25,8 +26,8 @@ export class ExifEntity { | |||
| @Column({ type: 'bigint', nullable: true }) | |||
| fileSizeInByte!: number | null; | |||
|
|
|||
| @Column({ type: 'varchar', nullable: true }) | |||
| orientation!: string | null; | |||
| @Column({ type: 'enum', enum: Orientation, nullable: true }) | |||
There was a problem hiding this comment.
For this case, the keys are basically already enum values. It'd be nice to make this a "char" (not char) and use a check constraint that it's between 1-8. It's a 1 byte integer instead of a 4 byte float and doesn't have the string vs number ambiguity that an enum would have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3022
Use an enum for exif orientation, including sending it back in the asset response dtos.