feat(deployment): no env_file #14889
Draft
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With container consolidations, at this point the
env_filedirective is causing increased support burden for no benefit. I propose that we remove it and expressly declare the necessary variables.The only thing that we lose by removing env_file from ML is the
TZ, which I don't believe is needed. open to any discussion. This should be a non-breaking change, even for our copy pastersNot too sure how exactly to apply it to the dev and prod YAMLs but should be very easy, I can work on it if we move forward. One big benefit is eliminating a setup step for portainer users.