Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mobile): split store into entity and model #15666

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shenlong-tanwen
Copy link
Member

Changes made

  • Refactored the App Store to use the repository pattern
  • Split the Entity into two - Entity and Model / DTO to make it easier to replace the entity alone in the future
  • Moved the store repository to the domain folder. The idea is to have all business logic and handling inside the domain layer and expose the services to the presentation layer
lib/
├─ domain/
├─ presentation/
├─ utils/
  • The old store values are migrated to the new entity during the migration.
  • A stub User entity and DTO to add and remove them to the new store. The old User entity and repository has to be migrated to use the new ones during the user entity split

TODO

  • Domain test cases for the store repository
  • Domain test cases for the store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant