Ensure executability for all Python with a __main__ #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither of the scripts I needed to run to reproduce the robotfindskitten results was executable, which strikes me as an easily-eliminated point of friction, so here's a patch to do so. The way I did it had the side effect of making the interpreter lines identical across all of the scripts. (Some of the existing scripts included an extra, but harmless, space.) For each Python script with a __main__ block, I ran each of these three steps: - delete existing interpreter if any: `sed -i '2,$b; /^#!/d'` - insert interpreter: `sed -i '1i#!/usr/bin/env python3'` - set executable permission bit: `chmod a+x` To apply those steps to the right files, I prefixed each command with: git grep -lFw __main__ '*.py' ':^:**/__main__.py' | xargs
TheDan64
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither of the scripts I needed to run to reproduce the robotfindskitten results was executable, which strikes me as an easily-eliminated point of friction, so here's a patch to do so.
The way I did it had the side effect of making the interpreter lines identical across all of the scripts. (Some of the existing scripts included an extra, but harmless, space.)
For each Python script with a
__main__block, I ran each of these three steps:sed -i '2,$b; /^#!/d'sed -i '1i#!/usr/bin/env python3'chmod a+xTo apply those steps to the right files, I prefixed each command with: