Update the Travis script to run on Linux and OS X #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, the `.travis.yml` (Travis build script) has been updated to build and test on both Linux and OS X. To achieve this the `script` portion of the script, checks for the os type and runs the correct provisioning script accordingly. Another change is, `matrix` was added, and this sets the correct environment variables depending on the os.
|
You seem to be mixing two styles in the multi-os guidelines, one style is: the other is the "matrix" style, e.g.: why is that? |
|
@thedataking that's what I seen from various other sources (a lot of the |
Added `python3-setuptools` to the linux provisioning script, because the travis xenial box does not seem to install recommended packages. Also moved `os: linux` into `matrix:` within the travis script.
|
@miguelsaldivar I had two minor comments, other than that, this looks ready to merge! |
thedataking
approved these changes
Jan 31, 2019
thedataking
reviewed
Jan 31, 2019
.travis.yml
Outdated
| - ./scripts/provision_mac.sh | ||
| - | | ||
| if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then | ||
| # - HOMEBREW_NO_AUTO_UPDATE=1 brew upgrade python |
There was a problem hiding this comment.
Should be # HOMEBREW_NO_AUTO_UPDATE=1 brew upgrade python. Otherwise, uncommenting the line would not work.
There was a problem hiding this comment.
Yup, that makes sense. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, the
.travis.yml(Travis build script) has beenupdated to build and test on both Linux and OS X. To achieve this
the
scriptportion of the script, checks for the os type and runsthe correct provisioning script accordingly. Another change is,
matrixwas added, and this sets the correct environment variables depending on
the os.