Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(passport): Fix location.href in redirect-callback to envs that use the base_path configuration #2557

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

rodrigo-fournier-immutable
Copy link
Contributor

Add rule to validate if application is using base_path configuration before forwarding using location.href in login redirect-callback.

@rodrigo-fournier-immutable rodrigo-fournier-immutable requested a review from a team as a code owner February 26, 2025 00:22
Copy link

nx-cloud bot commented Feb 26, 2025

View your CI Pipeline Execution ↗ for commit 862367f.

Command Status Duration Result
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1s View ↗
nx affected -t build,lint,test ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-26 00:44:43 UTC

@rodrigo-fournier-immutable rodrigo-fournier-immutable changed the title fix(passport): Fix location.href to envs that use the base_path config fix(passport): Fix location.href in redirec-callback to envs that use the base_path configuration Feb 26, 2025
@rodrigo-fournier-immutable rodrigo-fournier-immutable changed the title fix(passport): Fix location.href in redirec-callback to envs that use the base_path configuration fix(passport): Fix location.href in redirect-callback to envs that use the base_path configuration Feb 26, 2025
@rodrigo-fournier-immutable rodrigo-fournier-immutable added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 4a7d0d9 Feb 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants