Add URI scheme and domain to issue url #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkblotty
reviewed
Sep 4, 2024
| @@ -48,7 +48,7 @@ const handleIssueGroups = (allIssuesCreated: QueryGroup[], allIssueComments: Que | |||
| // make sure that comment belongs to a PR group | |||
| if (!finalIssues.secondary[issueUrl]) { | |||
| finalIssues.secondary[issueUrl] = { | |||
| groupTitle: `Left comments on issue: [${comment.issue.title}](${issueUrl}) in ${repoGroup.repo}`, | |||
| groupTitle: `Left comments on issue: [${comment.issue.title}](https://github.com${issueUrl}) in ${repoGroup.repo}`, | |||
There was a problem hiding this comment.
This looks ok 👍 We just need some updated tests please :)
There was a problem hiding this comment.
Added a test for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to the issue (as the group title for comments) is incorrect. Instead of having the full URL, it has the structure
/<ORG>/<REPO>/issues/<ISSUE_NUMBER>. Clicking it (at least in Arc) results in a 404.