Skip to content

Commit

Permalink
This will hopefully fix that bug
Browse files Browse the repository at this point in the history
Because of the way the code works, and new Date objects, the end of term 3 (and the end of the school year) is set to June 23 at 00:00 meaning there is no more school at any time after 00:00 on June 23. Adding 23:59 should make it so it thinks there's school on the day of the 23 of June as well : )
  • Loading branch information
insberr authored Jun 23, 2023
1 parent c27c3df commit 4834183
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/config/settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,15 @@ export const scheduleConfigs = {
],
};

export const lastDayOfSchool = new Date('June 23, 2023');
export const lastDayOfSchool = new Date('June 23, 2023 23:59');
// Terms
// This is also used to determine the number of terms in the school year
// This valuse is REQUIRED else there will be an error
// This valuse is REQUIRED else there will be an error
//
// `endDate` is by default set with an end time of 00:00 (12am)
// due to the way the code works, it is advised that you specify the time
// this would in most cases be 23:59 (11:59pm)
// See const lastDayOfSchool for time example
export const termsDates: types.Terms = [
{
termIndex: 0,
Expand Down

0 comments on commit 4834183

Please sign in to comment.