Bug 1736368 - Use consistent min-heights for moz-tree-row and tree co…

…lumn headers. r=desktop-theme-reviewers,dao

I couldn't reproduce this neither in Windows 10 nor 11 (the tree columns are
small, but that happens both in light and dark mode).

It is true, however, that the col pickers are too small generally on all
platforms as well, so this seems reasonable.

Differential Revision: https://phabricator.services.mozilla.com/D128751

browser/components/places/tests/browser/browser_views_iconsupdate.js

@@ -55,6 +55,9 @@ add_task(async function() {
   let sidebarRect = await getRectForSidebarItem(bm.guid);
   let sidebarShot1 = TestUtils.screenshotArea(sidebarRect, window);
 
+  info("Toolbar: " + toolbarShot1);
+  info("Sidebar: " + sidebarShot1);
+
   let iconURI = await new Promise(resolve => {
     PlacesUtils.favicons.setAndFetchFaviconForPage(
       PAGE_URI,
@@ -74,7 +77,6 @@ add_task(async function() {
     // debugging purposes.
     let toolbarShot2 = TestUtils.screenshotArea(toolbarElt, window);
     if (toolbarShot1 != toolbarShot2) {
-      info("Before toolbar: " + toolbarShot1);
       info("After toolbar: " + toolbarShot2);
     }
     return toolbarShot1 != toolbarShot2;
@@ -83,7 +85,6 @@ add_task(async function() {
   await TestUtils.waitForCondition(() => {
     let sidebarShot2 = TestUtils.screenshotArea(sidebarRect, window);
     if (sidebarShot1 != sidebarShot2) {
-      info("Before sidebar: " + sidebarShot1);
       info("After sidebar: " + sidebarShot2);
     }
     return sidebarShot1 != sidebarShot2;

browser/themes/windows/places/organizer.css

@@ -223,7 +223,6 @@
 /* Tree */
 
 #contentView treecol {
-  padding: 4px;
   /* Use box-shadow to draw a bottom border instead of border-bottom
    * because otherwise the items on contentView won't be perfectly
    * aligned with the items on the sidebar. */

toolkit/themes/shared/tree.inc.css

@@ -23,6 +23,11 @@ tree {
 
 treechildren::-moz-tree-row {
   border: 1px solid transparent;
+}
+
+treechildren::-moz-tree-row,
+treecol:not([hideheader="true"]),
+treecolpicker {
   min-height: 24px;
   height: 1.3em;
 }