Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-6550 revise severity of alerts and timing #3537

Merged

Conversation

MStokluska
Copy link
Member

Issue link

https://issues.redhat.com/browse/MGDAPI-6550

What

Updated severity of the alerts and their timing

Verification steps

n/a

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mstokluska. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.66%. Comparing base (db6ff6f) to head (47db53d).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3537      +/-   ##
==========================================
- Coverage   47.67%   47.66%   -0.01%     
==========================================
  Files          95       95              
  Lines       13568    13566       -2     
==========================================
- Hits         6468     6466       -2     
  Misses       6388     6388              
  Partials      712      712              
Files with missing lines Coverage Δ
pkg/resources/metrics.go 75.00% <100.00%> (-0.10%) ⬇️

},
Expr: intstr.FromString(installationName + `_version{version=~".+", to_version=""} * on(pod) (installation_controller_reconcile_delayed == 1)`),
For: "1m",
Labels: map[string]string{"severity": "warning", "product": installationName},
For: "90m",
Copy link
Contributor

@valerymo valerymo Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it correct? Installation delay 90 min? Seems to me it can be 15 min Critical.
For example - ThreeScaleApicastProductionPod - 15 min Critical. Seems to me this one also can be similar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct Valery, we discussed and agreed on call

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we discussed. Thanks.

@valerymo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2025
@briangallagher briangallagher merged commit 2d59f3a into integr8ly:master Feb 12, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants