-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGDAPI-6550 revise severity of alerts and timing #3537
MGDAPI-6550 revise severity of alerts and timing #3537
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3537 +/- ##
==========================================
- Coverage 47.67% 47.66% -0.01%
==========================================
Files 95 95
Lines 13568 13566 -2
==========================================
- Hits 6468 6466 -2
Misses 6388 6388
Partials 712 712
|
}, | ||
Expr: intstr.FromString(installationName + `_version{version=~".+", to_version=""} * on(pod) (installation_controller_reconcile_delayed == 1)`), | ||
For: "1m", | ||
Labels: map[string]string{"severity": "warning", "product": installationName}, | ||
For: "90m", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it correct? Installation delay 90 min? Seems to me it can be 15 min Critical.
For example - ThreeScaleApicastProductionPod - 15 min Critical. Seems to me this one also can be similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct Valery, we discussed and agreed on call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we discussed. Thanks.
/lgtm |
Issue link
https://issues.redhat.com/browse/MGDAPI-6550
What
Updated severity of the alerts and their timing
Verification steps
n/a