🎨 Autodetect scoped enums in generated .cpp catalog file
#751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
auto-enum-log
branch
2 times, most recently
from
fcbe3df to
f0613d8
Compare
mjcaisse-intel
force-pushed
the
auto-enum-log
branch
from
f8312da to
c2e162b
Compare
Problem: - The `.cpp` file generated by `gen_str_catalog` requires headers to be supplied in order to define the enums used. If the headers are not supplied, it does not compile. Solution: - Export scoped enum information sufficient to forward declare enumerations. If headers are not supplied, the `.cpp` file should still compile. Note: - Unscoped enums cannot be forward declared. - Enums inside anonymous namespaces cannot be forward declared.
elbeno
force-pushed
the
auto-enum-log
branch
from
c2e162b to
a696f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
.cppfile generated bygen_str_catalogrequires headers to be supplied in order to define the enums used. If the headers are not supplied, it does not compile.Solution:
.cppfile should still compile.Note: