🎨 Expose logging::panic for use with custom log levels
#773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Most of the CIB logging macros allow easy use of a custom log level type, but `CIB_FATAL` does not, because the log level is injected by the `logging::detail::panic` function. Solution: - Lift the injection to the `CIB_FATAL` macro and lift `panic` into the `logging` namespace so that it is comparatively easy to issue a FATAL log with a custom level type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
CIB_FATALdoes not, because the log level is injected by thelogging::detail::panicfunction.Solution:
CIB_FATALmacro and liftpanicinto theloggingnamespace so that it is comparatively easy to issue a FATAL log with a custom level type.