Skip to content

Event pool cache leak fix #18325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

Conversation

winstonzhang-intel
Copy link
Contributor

@winstonzhang-intel winstonzhang-intel commented May 5, 2025

addresses event pool leak when SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING is set to 1

@winstonzhang-intel winstonzhang-intel changed the title Event pool cache Event pool cache leak fix May 5, 2025
@winstonzhang-intel winstonzhang-intel marked this pull request as ready for review May 6, 2025 04:24
@winstonzhang-intel winstonzhang-intel requested a review from a team as a code owner May 6, 2025 04:24
Addresses event pool leak when SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING
is set. Improper cleanup in getFreeSlotInExistingOrNewPool.

Signed-off-by: Zhang, Winston <[email protected]>
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrspruit
Copy link
Contributor

@intel/llvm-gatekeepers , please merge when available.

@sarnex sarnex merged commit f2ac846 into intel:sycl Jul 29, 2025
42 of 47 checks passed
@aelovikov-intel
Copy link
Contributor

No [UR] tag in the title and no test added?

@sarnex
Copy link
Contributor

sarnex commented Jul 29, 2025

I added the tag myself when merging. For tests I leave that to the reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants