Fix coverity issues by passing shared pointer by reference. #18473
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
force-pushed
the
fabio/fix_coverity
branch
from
3ff8738 to
b85e029
Compare
fabiomestre
force-pushed
the
fabio/fix_coverity
branch
from
b85e029 to
4aee6ce
Compare
fabiomestre
force-pushed
the
fabio/fix_coverity
branch
from
4aee6ce to
0e74543
Compare
reble
reviewed
May 14, 2025
| @@ -1024,7 +1024,7 @@ exec_graph_impl::enqueue(const std::shared_ptr<sycl::detail::queue_impl> &Queue, | |||
| for (std::vector<sycl::detail::EventImplPtr>::iterator It = | |||
| MExecutionEvents.begin(); | |||
| It != MExecutionEvents.end();) { | |||
| auto Event = *It; | |||
| std::shared_ptr<event_impl> &Event = *It; | |||
There was a problem hiding this comment.
Suggested change
| std::shared_ptr<event_impl> &Event = *It; | |
| auto &Event = *It; |
This should work too if we want to have it less explicit as before and only use a reference ... or was that change intentional?
There was a problem hiding this comment.
The change was intentional. I thought having it explicit was slightly more readable. But I don't feel that strongly about it. I'm ok with reverting if you have a preference for auto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes some functions in the sycl graph implementation to pass shared pointers by reference instead of by value.
Fixes: #18412