[libspirv][generic] re-use __clc_ctz implementation for __spirv_ocl_ctz #18478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasercrmck
approved these changes
May 15, 2025
There was a problem hiding this comment.
LGTM. Thanks for doing these cleanups! There's still a few more to deal with, IIRC.
As an aside, I've been wanting to look into how we deal with schar and hopefully move it into the remangler. I managed it for fp16 vs Float16 and I don't think the problem is that different. Famous last words, of course.
The idea would be that we don't need to explicitly use schar anywhere and have all these differences from upstream and "pure" OpenCL C.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schar variant of __clc_ctz since libspirv requires schar variant.