Skip to content

[SYCL][Driver] Mark DeviceLib option as deprecated #18581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 25, 2025
Merged

[SYCL][Driver] Mark DeviceLib option as deprecated #18581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1cc5363
[SYCL][Driver] Mark DeviceLib option as deprecated
jinge90 May 21, 2025
ec63ea9
Merge remote-tracking branch 'upstream/sycl' into deprecate_devicelib…
jinge90 May 30, 2025
f498bd5
Clear tests using fsycl-device-lib-jit-link
jinge90 May 30, 2025
122b5da
fix some unsupported
jinge90 May 30, 2025
cb10718
Merge remote-tracking branch 'upstream/sycl' into deprecate_devicelib…
jinge90 Jun 12, 2025
598a38d
update no-unsupported-without-info list
jinge90 Jun 12, 2025
4726947
resolve conflicts
jinge90 Jun 17, 2025
43202ee
fix lit failure
jinge90 Jun 17, 2025
a5a6ca3
add deprecated test for fsycl-device-lib
jinge90 Jun 18, 2025
7e685de
resolve conflict
jinge90 Jun 18, 2025
87b08ca
Merge remote-tracking branch 'upstream/sycl' into deprecate_devicelib…
jinge90 Jun 18, 2025
8773a42
Merge remote-tracking branch 'upstream/sycl' into deprecate_devicelib…
jinge90 Jun 19, 2025
102e83f
Merge remote-tracking branch 'upstream/sycl' into deprecate_devicelib…
jinge90 Jun 23, 2025
fb33baf
revert driver lit test
jinge90 Jun 23, 2025
603d2b6
revert sycl e2e changes
jinge90 Jun 24, 2025
4a6d13e
Merge remote-tracking branch 'upstream/sycl' into deprecate_devicelib…
jinge90 Jun 25, 2025
2154477
apply no-deprecated option
jinge90 Jun 25, 2025
0193eee
apply more no-deprecated
jinge90 Jun 25, 2025
c7f9f31
fix windows build fail
jinge90 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions clang/include/clang/Driver/Options.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7091,19 +7091,22 @@ def fsycl_dead_args_optimization : Flag<["-"], "fsycl-dead-args-optimization">,
def fno_sycl_dead_args_optimization : Flag<["-"], "fno-sycl-dead-args-optimization">,
HelpText<"Disables elimination of DPC++ dead kernel arguments">;
def fsycl_device_lib_EQ : CommaJoined<["-"], "fsycl-device-lib=">,
Flags<[NoXarchOption]>,
Flags<[Deprecated]>,
Values<"libc,libm-fp32,libm-fp64,libimf-fp32,libimf-fp64,libimf-bf16,all">,
HelpText<"Control inclusion of device libraries into device binary linkage. "
"Valid arguments are libc, libm-fp32, libm-fp64, libimf-fp32, "
"libimf-fp64, libimf-bf16, all">;
"libimf-fp64, libimf-bf16, all. (deprecated)">;
def fno_sycl_device_lib_EQ : CommaJoined<["-"], "fno-sycl-device-lib=">,
Flags<[NoXarchOption]>, Values<"libc, libm-fp32, libm-fp64, all">,
Flags<[Deprecated]>,
Values<"libc, libm-fp32, libm-fp64, all">,
HelpText<"Control exclusion of device libraries from device binary linkage. "
"Valid arguments are libc, libm-fp32, libm-fp64, all">;
"Valid arguments are libc, libm-fp32, libm-fp64, all. (deprecated)">;
def fsycl_device_lib_jit_link : Flag<["-"], "fsycl-device-lib-jit-link">,
HelpText<"Enables sycl device library jit link (experimental)">;
Flags<[Deprecated]>,
HelpText<"Enables sycl device library jit link. (deprecated)">;
def fno_sycl_device_lib_jit_link : Flag<["-"], "fno-sycl-device-lib-jit-link">,
HelpText<"Disables sycl device library jit link (experimental)">;
Flags<[Deprecated]>,
HelpText<"Disables sycl device library jit link. (deprecated)">;
def fsycl_fp32_prec_sqrt : Flag<["-"], "fsycl-fp32-prec-sqrt">,
Alias<foffload_fp32_prec_sqrt>, Flags<[Deprecated]>,
Visibility<[ClangOption, CC1Option]>, HelpText<"SYCL only. Specify that "
Expand Down
8 changes: 8 additions & 0 deletions clang/test/Driver/sycl-deprecated.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@
// RUN: %clangxx -fsycl -fsycl-fp32-prec-sqrt %s -### 2>&1 | FileCheck %s --check-prefix=CHECK_REPLACE -DOPTION=-fsycl-fp32-prec-sqrt -DOPTION_REPLACE=-foffload-fp32-prec-sqrt
// RUN: %clangxx -fsycl -fsycl-dump-device-code=/path/to/spv/ %s -### 2>&1 | FileCheck %s --check-prefix=CHECK_REPLACE -DOPTION=-fsycl-dump-device-code=/path/to/spv/ -DOPTION_REPLACE=-save-offload-code=/path/to/spv/
// CHECK_REPLACE: option '[[OPTION]]' is deprecated and will be removed in a future release, use '[[OPTION_REPLACE]]' instead

// RUN: %clangxx -fsycl -fsycl-device-lib-jit-link %s -### 2>&1 \
// RUN: | FileCheck %s --check-prefix=CHECK -DOPTION=-fsycl-device-lib-jit-link
// RUN: %clangxx -fsycl -fsycl-device-lib=libc %s -### 2>&1 \
// RUN: | FileCheck %s --check-prefix=CHECK -DOPTION=-fsycl-device-lib=libc
// RUN: %clangxx -fsycl -fno-sycl-device-lib=libc %s -### 2>&1 \
// RUN: | FileCheck %s --check-prefix=CHECK -DOPTION=-fno-sycl-device-lib=libc

2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceImageDependencies/NewOffloadDriver/math_device_lib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}

// RUN: %{build} --offload-new-driver -fsycl-allow-device-image-dependencies %if target-spir %{ -fsycl-device-lib-jit-link %} %{mathflags} -o %t.out
// RUN: %{build} --offload-new-driver -fsycl-allow-device-image-dependencies %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} %{mathflags} -o %t.out
// RUN: %{run} %t.out

#include <cmath>
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceImageDependencies/math_device_lib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}

// RUN: %{build} -fsycl-allow-device-image-dependencies %if target-spir %{ -fsycl-device-lib-jit-link %} %{mathflags} -o %t.out
// RUN: %{build} -fsycl-allow-device-image-dependencies %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} %{mathflags} -o %t.out
// RUN: %{run} %t.out

#include <cmath>
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/cmath_fp64_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// RUN: %{build} %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -Wno-deprecated %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{run} %t2.out %}

#include "math_utils.hpp"
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/cmath_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// RUN: %{build} -fno-builtin %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fno-builtin -fsycl-device-lib-jit-link %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fno-builtin -fsycl-device-lib-jit-link -Wno-deprecated %{mathflags} -o %t2.out %}
// RUN: %if target-spir && !gpu %{ %{run} %t2.out %}
//
// // Check that --fast-math works with cmath funcs for CUDA
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_bfloat16_integeral_convesions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_double2bfloat16.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t1.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t1.out
// RUN: %{run} %t1.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_double2half.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out

// UNSUPPORTED: target-nvidia, target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_float2bfloat16.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_fp32_rounding_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_fp32_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_fp64_rounding_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_fp64_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_fp64_test2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_half_type_cast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out

// UNSUPPORTED: target-nvidia, target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/imf_simd_emulate_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link %} -o %t2.out
// RUN: %{build} -fno-builtin %if target-spir %{ -fsycl-device-lib-jit-link -Wno-deprecated %} -o %t2.out
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/math_fp64_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// RUN: %{build} %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -Wno-deprecated %{mathflags} -o %t2.out %}
// RUN: %if target-spir && !gpu %{ %{run} %t2.out %}

#include "math_utils.hpp"
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/math_fp64_windows_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// RUN: %{build} %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -Wno-deprecated %{mathflags} -o %t2.out %}
// RUN: %if target-spir && !gpu %{ %{run} %t2.out %}

#include "math_utils.hpp"
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/math_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// RUN: %{build} %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -Wno-deprecated %{mathflags} -o %t2.out %}
// RUN: %if target-spir && !gpu %{ %{run} %t2.out %}

#include "math_utils.hpp"
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/math_windows_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// RUN: %{build} %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -Wno-deprecated %{mathflags} -o %t2.out %}
// RUN: %if target-spir && !gpu %{ %{run} %t2.out %}

#include "math_utils.hpp"
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// RUN: %{build} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -Wno-deprecated -o %t2.out %}
// RUN: %if target-spir %{ %{run} %t2.out %}

#include <array>
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/std_complex_math_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// RUN: %{build} %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{build} -fsycl-device-lib-jit-link -Wno-deprecated %{mathflags} -o %t2.out %}
// RUN: %if target-spir %{ %{run} %t2.out %}

#include <array>
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/DeviceLib/string_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %{build} -Wno-error=deprecated-declarations -Wno-error=pointer-to-int-cast -fno-builtin -o %t1.out
// RUN: %{run} %t1.out
//
// RUN: %if target-spir %{ %{build} -Wno-error=deprecated-declarations -Wno-error=pointer-to-int-cast -fno-builtin -fsycl-device-lib-jit-link -o %t2.out %}
// RUN: %if target-spir %{ %{build} -Wno-error=deprecated-declarations -Wno-error=pointer-to-int-cast -fno-builtin -fsycl-device-lib-jit-link -Wno-deprecated -o %t2.out %}
// RUN: %if target-spir && !gpu %{ %{run} %t2.out %}

#include <cassert>
Expand Down