[SYCL][E2E] Mark imf test as unsupported intended for cuda/hip #19000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Jun 16, 2025
There was a problem hiding this comment.
I suggest we move all tests with imf_ prefix to a separate imf directory.
I.e.
sycl/test-e2e/DeviceLib/imf_<test_name>.cpp ->
sycl/test-e2e/DeviceLib/imf/<test_name>.cpp
Adding sycl/test-e2e/DeviceLib/imf/lit.local.cfg with
import platform
config.unsupported_features += ['target-nvidia', 'target-amd']
should simplify the maintenance efforts.
There was a problem hiding this comment.
Agreed, I'll wait for #18995 as it would conflict, and then re-work the patch as suggested.
We don't support IMF in CUDA/HIP and have no plans of supporting it.
cperkinsintel
approved these changes
Jun 23, 2025
bader
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support IMF in CUDA/HIP and have no plans of supporting it.