[SYCL][Clang] Rename -Wno-libspirv-hip-cuda to -Wunsafe-libspirv-not-linked
#19053
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot-linked` IMO there are a few problems with the current name: - Its negative option form `-Wno-no-libspirv-hip-cuda` is very awkward. - It is very specific about the HIP or CUDA backend, which does not allow for future expansion to other backend, that could use libspirv. - It's not very descriptive in general: in other words, without the context of the error message, what it does.
|
Ping @intel/dpcpp-clang-driver-reviewers @intel/dpcpp-cfe-reviewers |
Fznamznon
approved these changes
Jun 24, 2025
mdtoguchi
approved these changes
Jun 24, 2025
|
@intel/llvm-gatekeepers this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO there are a few problems with the current name:
-Wno-no-libspirv-hip-cudais very awkward.