[UR][HIP] Select the correct binary in a multi-arch bundle #19092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the HIP adapter to select the correct binary for the device when a bundle contains binaries built for multiple AMDGPU architectures. Similarly to other adapaters, the HIP adapter would previously select the first 'amdgcn' binary it came across. This works fine for the common case where the program was compiled for one architecture but may fail otherwise. To aid in this, the SYCL runtime passes some extra information into urDeviceSelectBinary via the pre-existing 'pNext' field of ur_device_binary_t. It does this only for the HIP backend. The HIP adapater then parses this binary information as a clang offload bundle, which conveniently contains specific triple & architecture information for each binary. For this we re-use the code that the offload adapter was using, making it common and fixing a bug in the version matching logic.
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
reviewed
Jun 23, 2025
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
reviewed
Jun 23, 2025
RossBrunton
reviewed
Jun 23, 2025
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
reviewed
Jun 24, 2025
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
approved these changes
Jun 24, 2025
|
@intel/llvm-gatekeepers this is ready to merge - thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the HIP adapter to select the correct binary for the device when a bundle contains binaries built for multiple AMDGPU architectures.
Similarly to other adapaters, the HIP adapter would previously select the first 'amdgcn' binary it came across. This works fine for the common case where the program was compiled for one architecture but may fail otherwise.
To aid in this, the SYCL runtime passes some extra information into urDeviceSelectBinary via the pre-existing 'pNext' field of ur_device_binary_t. It does this only for the HIP backend. The HIP adapater then parses this binary information as a clang offload bundle, which conveniently contains specific triple & architecture information for each binary. For this we re-use the code that the offload adapter was using, making it common and fixing a bug in the version matching logic.