Skip to content

[NFC][UR] Don't check for __cplusplus in cpp files #19112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

RossBrunton
Copy link
Contributor

Unless something has gone terribly wrong, the compiler used to compile
cpp files will be a cpp compiler.

Unless something has gone terribly wrong, the compiler used to compile
cpp files will be a cpp compiler.
@RossBrunton RossBrunton requested review from a team as code owners June 24, 2025 12:13
@RossBrunton RossBrunton requested a review from ldrumm June 24, 2025 12:13
Copy link
Contributor

@ldrumm ldrumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can't quite imagine the situation in which isn't the correct thing to do, and don't really want to. Nice cleanup

@RossBrunton
Copy link
Contributor Author

@intel/unified-runtime-reviewers-level-zero Mind having a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants