[SYCL][E2E] Minor OpenCL KernelCompiler Test Reorg #19124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Jun 25, 2025
|
|
||
| // only one device is supported at this time, so we limit the queue and | ||
| // context to that | ||
| sycl::device d{sycl::default_selector_v}; |
There was a problem hiding this comment.
Suggested change
| sycl::device d{sycl::default_selector_v}; | |
| sycl::device D{sycl::default_selector_v}; |
| // only one device is supported at this time, so we limit the queue and | ||
| // context to that | ||
| sycl::device d{sycl::default_selector_v}; | ||
| sycl::context ctx{d}; |
There was a problem hiding this comment.
Suggested change
| sycl::context ctx{d}; | |
| sycl::context Ctx{d}; |
| // context to that | ||
| sycl::device d{sycl::default_selector_v}; | ||
| sycl::context ctx{d}; | ||
| sycl::queue q{ctx, d}; |
There was a problem hiding this comment.
Suggested change
| sycl::queue q{ctx, d}; | |
| sycl::queue Q{ctx, d}; |
| sycl::context ctx{d}; | ||
| sycl::queue q{ctx, d}; | ||
|
|
||
| bool ok = |
There was a problem hiding this comment.
Suggested change
| bool ok = | |
| bool Ok = |
| return; | ||
| } | ||
|
|
||
| source_kb kbSrc = syclex::create_kernel_bundle_from_source( |
There was a problem hiding this comment.
Suggested change
| source_kb kbSrc = syclex::create_kernel_bundle_from_source( | |
| source_kb KbSrc = syclex::create_kernel_bundle_from_source( |
| ctx, syclex::source_language::opencl, CLSource); | ||
| exe_kb kbExe1 = syclex::build(kbSrc); | ||
|
|
||
| sycl::kernel my_kernel = kbExe1.ext_oneapi_get_kernel("my_kernel"); |
There was a problem hiding this comment.
Suggested change
| sycl::kernel my_kernel = kbExe1.ext_oneapi_get_kernel("my_kernel"); | |
| sycl::kernel MyKernel = kbExe1.ext_oneapi_get_kernel("my_kernel"); |
| using source_kb = sycl::kernel_bundle<sycl::bundle_state::ext_oneapi_source>; | ||
| using exe_kb = sycl::kernel_bundle<sycl::bundle_state::executable>; | ||
|
|
||
| // only one device is supported at this time, so we limit the queue and |
There was a problem hiding this comment.
Suggested change
| // only one device is supported at this time, so we limit the queue and | |
| // Only one device is supported at this time, so we limit the queue and |
| using exe_kb = sycl::kernel_bundle<sycl::bundle_state::executable>; | ||
|
|
||
| // only one device is supported at this time, so we limit the queue and | ||
| // context to that |
There was a problem hiding this comment.
Suggested change
| // context to that | |
| // context to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking opencl kernel_compiler test up to not hit timeouts when building
-O0