[SYCL] [UR] [Graphs] Added missing UR_CALLs #19143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
force-pushed
the
konrad/smallFixes
branch
from
841e11d to
add1c26
Compare
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
force-pushed
the
konrad/smallFixes
branch
from
add1c26 to
55dae53
Compare
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
reviewed
Jun 26, 2025
There was a problem hiding this comment.
There's one more missing UR_CALL found by coverity: https://github.com/intel/llvm/blob/sycl/unified-runtime/source/adapters/level_zero/command_buffer.cpp#L1515-L1516
Can you fix that as well?
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Aye, thanks for pointing out. |
pbalcer
approved these changes
Jun 26, 2025
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
force-pushed
the
konrad/smallFixes
branch
from
8d259cc to
9f6893a
Compare
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
konradkusiak97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Bensuo
approved these changes
Jun 27, 2025
|
@intel/llvm-gatekeepers this is ready to merge, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes flagged by static analyzer:
UR_CALLandUR_CALL_NOCHECKtour::level_zerofunction calls in Command Buffer,shared_ptr