[libspirv] Implement SPIR-V vload builtins via CLC #19174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change to any target's generated bytecode.
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
approved these changes
Jun 27, 2025
| #define VLOAD_DEF(ADDRSPACE) \ | ||
| _CLC_OVERLOAD _CLC_DEF CLC_VLOAD_TY SPIRV_VLOAD_NAME()( \ | ||
| size_t offset, const ADDRSPACE __CLC_SCALAR_GENTYPE *x) { \ | ||
| return *((const ADDRSPACE CLC_VLOAD_TY *)(&x[offset])); \ |
There was a problem hiding this comment.
OpenCL spec doesn't define scalar variant of vloadn, right? Can we delete it?
There was a problem hiding this comment.
That's right, it's not defined. I'm not sure whether they can be removed - we'd first have to see if these builtins are actually being relied upon by the host/runtime. I can investigate that as a follow-up.
omarahmed1111
approved these changes
Jun 30, 2025
|
@intel/llvm-gatekeepers this is ready to merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to any target's generated bytecode.