[SYCL] Add one more WA on Win for shutdown process #19195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KseniyaTikhomirova
changed the title
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Failed tests are not unique for my PR: https://github.com/intel/llvm/actions/runs/15937270979/job/44966158959?pr=19205 |
cperkinsintel
approved these changes
Jul 14, 2025
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers hi, this PR is ready to be merged. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WA for host task threads handling.
We must call join() or detach() on host task execution thread to avoid UB.
DLLMain parameter lpReserved == NULL if library is unloaded via FreeLibrary.
In this case we can't join threads within DllMain call due to global loader lock
and DLL_THREAD_DETACH signalling.
lpReserved != NULL if library is unloaded during process termination. In this case
Windows terminates threads but leave them in signalled state, prevents
DLL_THREAD_DETACH notification and we can call join() as NOP.
Note that FreeLibrary called with sycl RT handle does not guarantee which path
will be used. Windows can (and actually does) simply postpone actual unloading
till the end of program.