Skip to content

[CI][NFC] Remove Windows driver listing in dependencies.json #19197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jun 27, 2025

We don't use this and it's all done manually, and JSON doesn't support comments, so just remove it to prevent confusion.

The tbb and oclcpu ones aren't used either, but it's updated by the team to have the download link we use to manually install, so keep those.

Issue: #19192

@sarnex sarnex marked this pull request as ready for review June 27, 2025 16:16
@sarnex sarnex requested a review from a team as a code owner June 27, 2025 16:16
@sarnex sarnex merged commit a7eb433 into intel:sycl Jun 27, 2025
17 of 35 checks passed
@bader
Copy link
Contributor

bader commented Jun 27, 2025

How do I know which driver is to use on my machine?

NOTE: This file is referenced in the GetStartedGuide. You must update the guide with new instructions how to get pre-requisites for SYCL compiler.

@sarnex
Copy link
Contributor Author

sarnex commented Jun 27, 2025

How do I know which driver is to use on my machine?

Sorry, not sure I understand the question. If you want to match CI you can check the sycl-ls logs, it will say.

NOTE: This file is referenced in the GetStartedGuide. You must update the guide with new instructions how to get pre-requisites for SYCL compiler.

Will do

@sarnex
Copy link
Contributor Author

sarnex commented Jun 27, 2025

I'll just update this json file, I don't want to deal with the doc

@sarnex
Copy link
Contributor Author

sarnex commented Jun 27, 2025

5dc9b12

@bader
Copy link
Contributor

bader commented Jun 27, 2025

If you want to match CI you can check the sycl-ls logs, it will say.

We can't seriously propose this to the SYCL compiler users.

I think we should follow Intel's oneAPI toolkit approach and provide instructions to get the latest version of the Windows GPU driver.

Using exact version of the driver was critical in the past when interface between SYCL compiler/runtime and GPU driver had been broken frequently. These days, it's much more stable, so using the latest version should be fine in general. Otherwise, @sarnex should update Windows GPU version each time the driver is update in CI.

@sarnex
Copy link
Contributor Author

sarnex commented Jun 27, 2025

I plan to update the json each time I update CI. If someone wants to update the doc and then remove the Windows entry from the json, go ahead, but I don't have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants