Skip to content

[SYCL] Provide length when converting to string view in preview mode #19212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Provide length when converting to string view in preview mode #19212

wants to merge 2 commits into from
+5 −0

Conversation

jchlanda
Copy link
Contributor

No description provided.

@jchlanda
Copy link
Contributor Author

This was discovered in RTC testing and was triggered from within make_kernel_bundle_from_source call.

@jchlanda jchlanda marked this pull request as ready for review June 30, 2025 13:02
@jchlanda jchlanda requested a review from a team as a code owner June 30, 2025 13:02
@jchlanda jchlanda requested a review from aelovikov-intel June 30, 2025 13:02
@jchlanda
Copy link
Contributor Author

Looks like strlen is constexpr only from c++ 20, will have to move to a loop.

@jchlanda jchlanda force-pushed the jakub/string_view branch from a9bb064 to 73a89c4 Compare June 30, 2025 13:27
aelovikov-intel
aelovikov-intel requested changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is existing data member len wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchlanda @aelovikov-intel