Skip to content

[NFC][SYCL] Prefer raw references in unittests/xpti_trace/QueueIDCheck.cpp #19218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
+14 −14
Merged

[NFC][SYCL] Prefer raw references in unittests/xpti_trace/QueueIDCheck.cpp #19218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions sycl/unittests/xpti_trace/QueueIDCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ TEST_F(QueueID, QueueID_QueueCreationAndDestroy) {
std::string Queue1IDSTr;
{
sycl::queue Q0{Context, sycl::default_selector{}};
auto Queue0ImplPtr = sycl::detail::getSyclObjImpl(Q0);
Queue0IDSTr = std::to_string(Queue0ImplPtr->getQueueID());
sycl::detail::queue_impl &Queue0Impl = *sycl::detail::getSyclObjImpl(Q0);
Queue0IDSTr = std::to_string(Queue0Impl.getQueueID());
ASSERT_TRUE(queryReceivedNotifications(TraceType, Message));
EXPECT_EQ(TraceType, xpti::trace_queue_create);
EXPECT_THAT(Message, HasSubstr("create:queue_id:" + Queue0IDSTr));
Expand All @@ -97,8 +97,8 @@ TEST_F(QueueID, QueueID_QueueCreationAndDestroy) {
std::to_string(size_t(QueueHandle))));

sycl::queue Q1{Context, sycl::default_selector{}};
auto Queue1ImplPtr = sycl::detail::getSyclObjImpl(Q1);
Queue1IDSTr = std::to_string(Queue1ImplPtr->getQueueID());
sycl::detail::queue_impl &Queue1Impl = *sycl::detail::getSyclObjImpl(Q1);
Queue1IDSTr = std::to_string(Queue1Impl.getQueueID());
ASSERT_TRUE(queryReceivedNotifications(TraceType, Message));
EXPECT_EQ(TraceType, xpti::trace_queue_create);
EXPECT_THAT(Message, HasSubstr("create:queue_id:" + Queue1IDSTr));
Expand All @@ -118,8 +118,8 @@ TEST_F(QueueID, QueueID_QueueCreationAndDestroy) {
TEST_F(QueueID, QueueCreationAndKernelWithDeps) {
sycl::queue Q0;
sycl::queue Q1;
auto Queue0ImplPtr = sycl::detail::getSyclObjImpl(Q0);
auto Queue1ImplPtr = sycl::detail::getSyclObjImpl(Q1);
sycl::detail::queue_impl &Queue0Impl = *sycl::detail::getSyclObjImpl(Q0);
sycl::detail::queue_impl &Queue1Impl = *sycl::detail::getSyclObjImpl(Q1);
sycl::buffer<int, 1> buf(sycl::range<1>(1));
Q1.submit(
[&](handler &Cgh) {
Expand All @@ -128,8 +128,8 @@ TEST_F(QueueID, QueueCreationAndKernelWithDeps) {
},
{FileName, FunctionName, 1, 0})
.wait();
EXPECT_NE(Queue1ImplPtr->getQueueID(), Queue0ImplPtr->getQueueID());
auto QueueIDSTr = std::to_string(Queue1ImplPtr->getQueueID());
EXPECT_NE(Queue1Impl.getQueueID(), Queue0Impl.getQueueID());
auto QueueIDSTr = std::to_string(Queue1Impl.getQueueID());
// alloca
checkTaskBeginEnd(QueueIDSTr);
// kernel
Expand All @@ -140,8 +140,8 @@ TEST_F(QueueID, QueueCreationAndKernelWithDeps) {
// https://github.com/intel/llvm/issues/12963
TEST_F(QueueID, DISABLED_QueueCreationUSMOperations) {
sycl::queue Q0;
auto Queue0ImplPtr = sycl::detail::getSyclObjImpl(Q0);
auto QueueIDSTr = std::to_string(Queue0ImplPtr->getQueueID());
sycl::detail::queue_impl &Queue0Impl = *sycl::detail::getSyclObjImpl(Q0);
auto QueueIDSTr = std::to_string(Queue0Impl.getQueueID());

unsigned char *AllocSrc = (unsigned char *)sycl::malloc_device(1, Q0);
unsigned char *AllocDst = (unsigned char *)sycl::malloc_device(1, Q0);
Expand All @@ -165,11 +165,11 @@ TEST_F(QueueID, QueueCreationAndKernelNoDeps) {
sycl::queue Q0;
sycl::queue Q1;

auto Queue0ImplPtr = sycl::detail::getSyclObjImpl(Q0);
auto Queue0IDSTr = std::to_string(Queue0ImplPtr->getQueueID());
sycl::detail::queue_impl &Queue0Impl = *sycl::detail::getSyclObjImpl(Q0);
auto Queue0IDSTr = std::to_string(Queue0Impl.getQueueID());

auto Queue1ImplPtr = sycl::detail::getSyclObjImpl(Q1);
auto Queue1IDSTr = std::to_string(Queue1ImplPtr->getQueueID());
sycl::detail::queue_impl &Queue1Impl = *sycl::detail::getSyclObjImpl(Q1);
auto Queue1IDSTr = std::to_string(Queue1Impl.getQueueID());

Q0.submit(
[&](handler &Cgh) {
Expand Down
Loading