[NFC][SYCL][Graph] Prepare for getSyclObjImpl to return raw ref #19224
+505
−570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm planning to change `getSyclObjImpl` to return a raw reference in a later patch, uploading a bunch of PRs in preparation to that to make the subsequent review easier.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Bensuo
reviewed
Jul 1, 2025
Bensuo
approved these changes
Jul 1, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Jul 1, 2025
Comment on lines
-889
to
-890
| } else if (GraphImpl->getEventForNode(RootNode), | ||
| sycl::detail::getSyclObjImpl(Node1)) { |
There was a problem hiding this comment.
This , doesn't make much sense to me, I assume it was supposed to be == (implemented on the right now). @intel/sycl-graphs-reviewers , @Bensuo can you confirm?
There was a problem hiding this comment.
Yes I think it is supposed to be == , guessing it was copied from an ASSERT_EQ or something and slipped through. If there any issues with the change we can disable the test and I'll make an internal issue to look into fixing it.
There was a problem hiding this comment.
Local build passed with my change, so I hope CI will work this time. Thanks for a quick reply!
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to change
getSyclObjImplto return a raw reference in a later patch, uploading a bunch of PRs in preparation to that to make the subsequent review easier.I also did
s/sycl::detail::getSyclObjImpl/getSyclObjImpl/ghere to increase readability and to make it simpler to perform the future patch by simplesed(and avoid multiline changes).This PR originated in
unittests/Extensions/CommandGraph, but I had to modifyisSimilarandhasSimilarStructurein the implementation itself too.