-
Notifications
You must be signed in to change notification settings - Fork 798
[CI] Add a container for release builds #19289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Our public releases should satisfy these requirements - https://vfxplatform.com Among them - glibc 2.28. The best way to achieve it - is to use ASWF images, which already have the required env. I've created a container based on aswf/ci-base:2025.1. The original image already contains CUDA SDK, but not ROCm. So I've additionally installed it using https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/quick-start.html for RHEL 8.10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments
dnf -y install rocm && \ | ||
dnf clean all && rm -rf /var/cache/dnf | ||
|
||
COPY scripts/docker_entrypoint.sh /docker_entrypoint.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use the install_build_tools script too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's not really needed here, build and all check-* tests pass already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
@sarnex could you please merge? pre-commit can be skipped, just fixed the file extension. |
Our public releases should satisfy these requirements - https://vfxplatform.com Among them - glibc 2.28. The best way to achieve it - is to use ASWF images, which already have the required env.
I've created a container based on aswf/ci-base:2025.1. The original image already contains CUDA SDK, but not ROCm. So I've additionally installed it using https://rocm.docs.amd.com/projects/install-on-linux/en/latest/install/quick-start.html for RHEL 8.10.