[SYCL][XPTI][NFC] Unify stream type #19399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data type which identifies an XPTI stream wasn't uniformly the same, even within XPTI itself different APIs expected different data type as a stream identifier. This PR introduces the `xpti::stream_id_t` type alias and uses it everywhere. Motivation for this PR is to address warnings produced by `-Wconversion`. We don't have that flag enabled yet, but it is a requirement per our SDL processes. It will be enabled in intel#19306
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
approved these changes
Jul 15, 2025
reble
approved these changes
Jul 15, 2025
AlexeySachkov
added a commit
that referenced
this pull request
Jul 23, 2025
#19399 made layout of `scheduler` class dependent on whether or not XPTI instrumentation is enabled. This caused issues with layout mismatch when `scheduler.hpp` is included directly from unit-tests, because macro enabling XPTI were not aligned between the RT and unit-tests. The issue was caught for scheduler unit-tests and fixed in #19399, but apparently we have more unit-tests which need scheduler. Internal testing discovered issues with buffer unit-tests. Therefore, re-applied the fix from #19399 globally to all unit-tests to prevent issues like this appearing in new and other existing unit-tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data type which identifies an XPTI stream wasn't uniformly the same, even within XPTI itself different APIs expected different data type as a stream identifier.
This PR introduces the
xpti::stream_id_ttype alias and uses it everywhere.Motivation for this PR is to address warnings produced by
-Wconversion. We don't have that flag enabled yet, but it is a requirement per our SDL processes. It will be enabled in #19306