[NFC][SYCL][Graph] Add iterator_range::to<Container>() helper
#19431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
nodes_range_to
branch
from
415c599 to
d5d008f
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
nodes_range_to
branch
from
d5d008f to
3a65af1
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Jul 14, 2025
sycl/source/detail/helpers.hpp
Outdated
| template <typename Container> | ||
| std::enable_if_t< | ||
| check_type_in_v<Container, std::vector<sycl_type>, | ||
| std::queue<value_type *>, std::vector<value_type *>>, |
There was a problem hiding this comment.
std::vector<value_type *> isn't used in this PR, but I have uses locally for my WIP patches related to device_impl raw ptrs/refs.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
nodes_range_to
branch
from
3a65af1 to
d63bb46
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
reble
reviewed
Jul 15, 2025
| node_type node::get_type() const { return impl->MNodeType; } | ||
|
|
||
| std::vector<node> node::get_predecessors() const { | ||
| return detail::createNodesFromImpls(impl->MPredecessors); | ||
| return impl->predecessors().to<std::vector<node>>(); |
There was a problem hiding this comment.
nit: Looks like this code path hits a gap in our tests, that we should close.
We only check for the size of the returned container, but never for its content ...
can do as a follow up. Unrelated to this PR.
uditagarwal97
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.