[UR][SYCL] Implement USM prefetch from device to host in SYCL runtime and UR #19437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianayl
changed the title
|
Hi @intel/unified-runtime-reviewers, mind if I get a review? Thanks in advance! |
reble
reviewed
Jul 30, 2025
sycl/test-e2e/Graph/RecordReplay/ext_oneapi_enqueue_functions_prefetch.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Pablo Reble <[email protected]>
|
There is a UR precommit failure for CUDA: it is unrelated to the changes here. The same test fails on latest commit of |
|
@intel/unified-runtime-reviewers Friendly ping |
kbenzie
approved these changes
Aug 13, 2025
|
@intel/unified-runtime-reviewers-level-zero Friendly Ping |
igchor
approved these changes
Aug 13, 2025
|
@intel/sycl-graphs-reviewers Could I get another review please? Thanks! |
adamfidel
approved these changes
Aug 14, 2025
|
@intel/llvm-gatekeepers PR ready for merge, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to control USM prefetch direction (host-to-device, device-to-host) in the enqueue_function extension:
sycl::ext::oneapi::experimental { enum class prefetch_type { device, host }; void prefetch(sycl::queue q, void* ptr, size_t numBytes, prefetch_type type = prefetch_type::device); void prefetch(sycl::handler &h, void* ptr, size_t numBytes, prefetch_type type = prefetch_type::device); }Note:
There is a test failure regarding a new ABI symbol: In order to not break the ABI, I added a new handler function to represent prefetch from device-to-host. Despite the precommit failures, this should not be an ABI-breaking change and thus be okay to merge.I modified the ABI symbols tests as a part of this PR.