[UR][NFC][CUDA-HIP] Add documentation in stream queue #19471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmiller
force-pushed
the
stream-queue-comments
branch
from
1ca81c9 to
bcafa91
Compare
This patch mostly just adds some more documentation in the stream queue implementation, but it also does a few other things: * Re-order members in more coherent groups. * Use `ur_<object>_t` instead of `ur_<object>_t_ *`, they are identical but the first one is nicer. * Remove unused `get()` member function.
npmiller
force-pushed
the
stream-queue-comments
branch
from
bcafa91 to
3c8838e
Compare
frasercrmck
approved these changes
Jul 17, 2025
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch mostly just adds some more documentation in the stream queue implementation, but it also does a few other things:
ur_<object>_tinstead ofur_<object>_t_ *, they are identical but the first one is nicer.get()member function.