Skip to content

[UR][CTS] Use ASSERT instead of EXPECT in test bodies #19494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

[UR][CTS] Use ASSERT instead of EXPECT in test bodies #19494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion unified-runtime/test/conformance/adapter/urAdapterRelease.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ TEST_P(urAdapterReleaseTest, Success) {
&referenceCountBefore, nullptr));

uint32_t referenceCountAfter = 0;
EXPECT_SUCCESS(urAdapterRelease(adapter));
ASSERT_SUCCESS(urAdapterRelease(adapter));
ASSERT_SUCCESS(urAdapterGetInfo(adapter, UR_ADAPTER_INFO_REFERENCE_COUNT,
sizeof(referenceCountAfter),
&referenceCountAfter, nullptr));
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/test/conformance/adapter/urAdapterRetain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ TEST_P(urAdapterRetainTest, Success) {
&referenceCountBefore, nullptr));

uint32_t referenceCountAfter = 0;
EXPECT_SUCCESS(urAdapterRetain(adapter));
ASSERT_SUCCESS(urAdapterRetain(adapter));
ASSERT_SUCCESS(urAdapterGetInfo(adapter, UR_ADAPTER_INFO_REFERENCE_COUNT,
sizeof(referenceCountAfter),
&referenceCountAfter, nullptr));
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/test/conformance/context/urContextRetain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ TEST_P(urContextRetainTest, Success) {

ASSERT_LT(prevRefCount, refCount);

EXPECT_SUCCESS(urContextRelease(context));
ASSERT_SUCCESS(urContextRelease(context));
}

TEST_P(urContextRetainTest, InvalidNullHandleContext) {
Expand Down
6 changes: 3 additions & 3 deletions unified-runtime/test/conformance/device/urDeviceRelease.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ TEST_P(urDeviceReleaseTest, Success) {
uint32_t prevRefCount = 0;
ASSERT_SUCCESS(uur::GetObjectReferenceCount(device, prevRefCount));

EXPECT_SUCCESS(urDeviceRelease(device));
ASSERT_SUCCESS(urDeviceRelease(device));

uint32_t refCount = 0;
ASSERT_SUCCESS(uur::GetObjectReferenceCount(device, refCount));
Expand Down Expand Up @@ -46,14 +46,14 @@ TEST_P(urDeviceReleaseTest, SuccessSubdevices) {
uint32_t prevRefCount = 0;
ASSERT_SUCCESS(uur::GetObjectReferenceCount(sub_device, prevRefCount));

EXPECT_SUCCESS(urDeviceRelease(sub_device));
ASSERT_SUCCESS(urDeviceRelease(sub_device));

uint32_t refCount = 0;
ASSERT_SUCCESS(uur::GetObjectReferenceCount(sub_device, refCount));

ASSERT_GT(prevRefCount, refCount);

EXPECT_SUCCESS(urDeviceRelease(sub_device));
ASSERT_SUCCESS(urDeviceRelease(sub_device));
}

TEST_P(urDeviceReleaseTest, InvalidNullHandle) {
Expand Down
4 changes: 2 additions & 2 deletions unified-runtime/test/conformance/device/urDeviceRetain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ TEST_P(urDeviceRetainTest, SuccessSubdevices) {

ASSERT_LT(prevRefCount, refCount);

EXPECT_SUCCESS(urDeviceRelease(sub_device));
EXPECT_SUCCESS(urDeviceRelease(sub_device));
ASSERT_SUCCESS(urDeviceRelease(sub_device));
ASSERT_SUCCESS(urDeviceRelease(sub_device));
}

TEST_P(urDeviceRetainTest, InvalidNullHandle) {
Expand Down
6 changes: 3 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueEventsWait.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ TEST_P(urEnqueueEventsWaitTest, Success) {
ASSERT_SUCCESS(urEnqueueMemBufferRead(queue2, dst_buffer, true, 0, size,
output.data(), 0, nullptr, nullptr));
ASSERT_EQ(input, output);
EXPECT_SUCCESS(urEventRelease(event1));
EXPECT_SUCCESS(urEventRelease(waitEvent));
EXPECT_SUCCESS(urEventRelease(event2));
ASSERT_SUCCESS(urEventRelease(event1));
ASSERT_SUCCESS(urEventRelease(waitEvent));
ASSERT_SUCCESS(urEventRelease(event2));
}

TEST_P(urEnqueueEventsWaitTest, InvalidNullHandleQueue) {
Expand Down
76 changes: 38 additions & 38 deletions unified-runtime/test/conformance/enqueue/urEnqueueEventsWaitWithBarrier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ struct urEnqueueEventsWaitWithBarrierTest

void TearDown() override {
if (src_buffer) {
EXPECT_SUCCESS(urMemRelease(src_buffer));
ASSERT_SUCCESS(urMemRelease(src_buffer));
}
if (dst_buffer) {
EXPECT_SUCCESS(urMemRelease(dst_buffer));
ASSERT_SUCCESS(urMemRelease(dst_buffer));
}
urMultiQueueTestWithParam::TearDown();
}
Expand Down Expand Up @@ -110,32 +110,32 @@ TEST_P(urEnqueueEventsWaitWithBarrierTest, Success) {
ur_event_handle_t waitEvent = nullptr;
ASSERT_SUCCESS(urEnqueueMemBufferCopy(queue1, src_buffer, dst_buffer, 0, 0,
size, 0, nullptr, &event1));
EXPECT_SUCCESS(EnqueueBarrier(queue2, 1, &event1, &waitEvent));
EXPECT_SUCCESS(urQueueFlush(queue2));
EXPECT_SUCCESS(urQueueFlush(queue1));
EXPECT_SUCCESS(urEventWait(1, &waitEvent));
ASSERT_SUCCESS(EnqueueBarrier(queue2, 1, &event1, &waitEvent));
ASSERT_SUCCESS(urQueueFlush(queue2));
ASSERT_SUCCESS(urQueueFlush(queue1));
ASSERT_SUCCESS(urEventWait(1, &waitEvent));

std::vector<uint32_t> output(count, 1);
EXPECT_SUCCESS(urEnqueueMemBufferRead(queue1, dst_buffer, true, 0, size,
ASSERT_SUCCESS(urEnqueueMemBufferRead(queue1, dst_buffer, true, 0, size,
output.data(), 0, nullptr, nullptr));
EXPECT_EQ(input, output);
EXPECT_SUCCESS(urEventRelease(waitEvent));
EXPECT_SUCCESS(urEventRelease(event1));
ASSERT_SUCCESS(urEventRelease(waitEvent));
ASSERT_SUCCESS(urEventRelease(event1));

ur_event_handle_t event2 = nullptr;
input.assign(count, 420);
EXPECT_SUCCESS(urEnqueueMemBufferWrite(queue2, src_buffer, true, 0, size,
ASSERT_SUCCESS(urEnqueueMemBufferWrite(queue2, src_buffer, true, 0, size,
input.data(), 0, nullptr, nullptr));
EXPECT_SUCCESS(urEnqueueMemBufferCopy(queue2, src_buffer, dst_buffer, 0, 0,
ASSERT_SUCCESS(urEnqueueMemBufferCopy(queue2, src_buffer, dst_buffer, 0, 0,
size, 0, nullptr, &event2));
EXPECT_SUCCESS(EnqueueBarrier(queue1, 1, &event2, &waitEvent));
EXPECT_SUCCESS(urQueueFlush(queue2));
EXPECT_SUCCESS(urQueueFlush(queue1));
EXPECT_SUCCESS(urEventWait(1, &waitEvent));
EXPECT_SUCCESS(urEnqueueMemBufferRead(queue2, dst_buffer, true, 0, size,
ASSERT_SUCCESS(EnqueueBarrier(queue1, 1, &event2, &waitEvent));
ASSERT_SUCCESS(urQueueFlush(queue2));
ASSERT_SUCCESS(urQueueFlush(queue1));
ASSERT_SUCCESS(urEventWait(1, &waitEvent));
ASSERT_SUCCESS(urEnqueueMemBufferRead(queue2, dst_buffer, true, 0, size,
output.data(), 0, nullptr, nullptr));
EXPECT_SUCCESS(urEventRelease(waitEvent));
EXPECT_SUCCESS(urEventRelease(event2));
ASSERT_SUCCESS(urEventRelease(waitEvent));
ASSERT_SUCCESS(urEventRelease(event2));
EXPECT_EQ(input, output);
}

Expand Down Expand Up @@ -181,15 +181,15 @@ TEST_P(urEnqueueEventsWaitWithBarrierOrderingTest,
constexpr uint32_t ONE = 1;
urEnqueueMemBufferWrite(queue, buffer, true, 0, sizeof(uint32_t), &ONE, 0,
nullptr, &event);
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 1, &event, nullptr));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 1, &event, nullptr));
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 0, nullptr,
&event));
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 1, &event, nullptr));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 1, &event, nullptr));
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 0, nullptr,
&event));
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 1, &event, nullptr));
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 1, &event, nullptr));
addHelper.ValidateBuffer(buffer, sizeof(uint32_t), 4004);
}
}
Expand All @@ -212,15 +212,15 @@ TEST_P(urEnqueueEventsWaitWithBarrierOrderingTest,
constexpr uint32_t ONE = 1;
urEnqueueMemBufferWrite(queue, buffer, true, 0, sizeof(uint32_t), &ONE, 0,
nullptr, nullptr);
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, &event));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, &event));
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 1, &event,
nullptr));
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, &event));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, &event));
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 1, &event,
nullptr));
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, &event));
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, &event));
addHelper.ValidateBuffer(buffer, sizeof(uint32_t), 4004);
}
}
Expand All @@ -242,17 +242,17 @@ TEST_P(urEnqueueEventsWaitWithBarrierOrderingTest, SuccessEventDependencies) {
constexpr uint32_t ONE = 1;
urEnqueueMemBufferWrite(queue, buffer, true, 0, sizeof(uint32_t), &ONE, 0,
nullptr, &event[0]);
EXPECT_SUCCESS(
ASSERT_SUCCESS(
urEnqueueEventsWaitWithBarrier(queue, 1, &event[0], &event[1]));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 1, &event[1],
&event[2]));
EXPECT_SUCCESS(
ASSERT_SUCCESS(
urEnqueueEventsWaitWithBarrier(queue, 1, &event[2], &event[3]));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 1, &event[3],
&event[4]));
EXPECT_SUCCESS(
ASSERT_SUCCESS(
urEnqueueEventsWaitWithBarrier(queue, 1, &event[4], &event[5]));
addHelper.ValidateBuffer(buffer, sizeof(uint32_t), 4004);
}
Expand All @@ -275,15 +275,15 @@ TEST_P(urEnqueueEventsWaitWithBarrierOrderingTest,
constexpr uint32_t ONE = 1;
urEnqueueMemBufferWrite(queue, buffer, true, 0, sizeof(uint32_t), &ONE, 0,
nullptr, nullptr);
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, nullptr));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, nullptr));
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, add_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 0, nullptr,
nullptr));
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, nullptr));
EXPECT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, nullptr));
ASSERT_SUCCESS(urEnqueueKernelLaunch(queue, mul_kernel, 1, &offset, &count,
nullptr, 0, nullptr, 0, nullptr,
nullptr));
EXPECT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, nullptr));
ASSERT_SUCCESS(urEnqueueEventsWaitWithBarrier(queue, 0, nullptr, nullptr));
addHelper.ValidateBuffer(buffer, sizeof(uint32_t), 4004);
}
}
2 changes: 1 addition & 1 deletion unified-runtime/test/conformance/enqueue/urEnqueueKernelLaunch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ TEST_P(urEnqueueKernelLaunchMultiDeviceTest, KernelLaunchReadDifferentQueues) {
nullptr, 0, nullptr, nullptr));

// Wait for the queue to finish executing.
EXPECT_SUCCESS(urEnqueueEventsWait(queues[0], 0, nullptr, nullptr));
ASSERT_SUCCESS(urEnqueueEventsWait(queues[0], 0, nullptr, nullptr));

// Then the remaining queues do blocking reads from the buffer. Since the
// queues target different devices this checks that any devices memory has
Expand Down
8 changes: 4 additions & 4 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,25 +121,25 @@ TEST_P(urEnqueueMemBufferCopyMultiDeviceTest, CopyReadDifferentQueues) {
ur_mem_handle_t dst_buffer = nullptr;
ASSERT_SUCCESS(urMemBufferCreate(context, UR_MEM_FLAG_READ_ONLY, size,
nullptr, &dst_buffer));
EXPECT_SUCCESS(urEnqueueMemBufferCopy(queues[0], buffer, dst_buffer, 0, 0,
ASSERT_SUCCESS(urEnqueueMemBufferCopy(queues[0], buffer, dst_buffer, 0, 0,
size, 0, nullptr, nullptr));

// Wait for the queue to finish executing.
EXPECT_SUCCESS(urEnqueueEventsWait(queues[0], 0, nullptr, nullptr));
ASSERT_SUCCESS(urEnqueueEventsWait(queues[0], 0, nullptr, nullptr));

// Then the remaining queues do blocking reads from the buffer. Since the
// queues target different devices this checks that any devices memory has
// been synchronized.
for (unsigned i = 1; i < queues.size(); ++i) {
const auto queue = queues[i];
std::vector<uint32_t> output(count, 0);
EXPECT_SUCCESS(urEnqueueMemBufferRead(queue, dst_buffer, true, 0, size,
ASSERT_SUCCESS(urEnqueueMemBufferRead(queue, dst_buffer, true, 0, size,
output.data(), 0, nullptr, nullptr));
for (unsigned j = 0; j < count; ++j) {
EXPECT_EQ(input, output[j])
<< "Result on queue " << i << " did not match at index " << j << "!";
}
}

EXPECT_SUCCESS(urMemRelease(dst_buffer));
ASSERT_SUCCESS(urMemRelease(dst_buffer));
}
22 changes: 11 additions & 11 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopyRect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,30 +101,30 @@ TEST_P(urEnqueueMemBufferCopyRectTestWithParam, Success) {
// Fill src buffer with sequentially increasing values.
std::vector<uint8_t> input(src_buffer_size, 0x0);
std::iota(std::begin(input), std::end(input), 0x0);
EXPECT_SUCCESS(urEnqueueMemBufferWrite(queue, src_buffer,
ASSERT_SUCCESS(urEnqueueMemBufferWrite(queue, src_buffer,
/* is_blocking */ true, 0,
src_buffer_size, input.data(), 0,
nullptr, nullptr));

ur_mem_handle_t dst_buffer = nullptr;
EXPECT_SUCCESS(urMemBufferCreate(context, UR_MEM_FLAG_READ_WRITE,
ASSERT_SUCCESS(urMemBufferCreate(context, UR_MEM_FLAG_READ_WRITE,
dst_buffer_size, nullptr, &dst_buffer));

// Zero destination buffer to begin with since the write may not cover the
// whole buffer.
const uint8_t zero = 0x0;
EXPECT_SUCCESS(urEnqueueMemBufferFill(queue, dst_buffer, &zero, sizeof(zero),
ASSERT_SUCCESS(urEnqueueMemBufferFill(queue, dst_buffer, &zero, sizeof(zero),
0, dst_buffer_size, 0, nullptr,
nullptr));

// Enqueue the rectangular copy between the buffers.
EXPECT_SUCCESS(urEnqueueMemBufferCopyRect(
ASSERT_SUCCESS(urEnqueueMemBufferCopyRect(
queue, src_buffer, dst_buffer, src_buffer_origin, dst_buffer_origin,
region, src_buffer_row_pitch, src_buffer_slice_pitch,
dst_buffer_row_pitch, dst_buffer_slice_pitch, 0, nullptr, nullptr));

std::vector<uint8_t> output(dst_buffer_size, 0x0);
EXPECT_SUCCESS(urEnqueueMemBufferRead(queue, dst_buffer,
ASSERT_SUCCESS(urEnqueueMemBufferRead(queue, dst_buffer,
/* is_blocking */ true, 0,
dst_buffer_size, output.data(), 0,
nullptr, nullptr));
Expand All @@ -139,8 +139,8 @@ TEST_P(urEnqueueMemBufferCopyRectTestWithParam, Success) {
EXPECT_EQ(expected, output);

// Cleanup.
EXPECT_SUCCESS(urMemRelease(src_buffer));
EXPECT_SUCCESS(urMemRelease(dst_buffer));
ASSERT_SUCCESS(urMemRelease(src_buffer));
ASSERT_SUCCESS(urMemRelease(dst_buffer));
}

struct urEnqueueMemBufferCopyRectTest : uur::urQueueTest {
Expand Down Expand Up @@ -321,26 +321,26 @@ TEST_P(urEnqueueMemBufferCopyRectMultiDeviceTest, CopyRectReadDifferentQueues) {
ur_mem_handle_t dst_buffer = nullptr;
ASSERT_SUCCESS(urMemBufferCreate(context, UR_MEM_FLAG_READ_ONLY, size,
nullptr, &dst_buffer));
EXPECT_SUCCESS(urEnqueueMemBufferCopyRect(
ASSERT_SUCCESS(urEnqueueMemBufferCopyRect(
queues[0], buffer, dst_buffer, {0, 0, 0}, {0, 0, 0}, {size, 1, 1}, size,
size, size, size, 0, nullptr, nullptr));

// Wait for the queue to finish executing.
EXPECT_SUCCESS(urEnqueueEventsWait(queues[0], 0, nullptr, nullptr));
ASSERT_SUCCESS(urEnqueueEventsWait(queues[0], 0, nullptr, nullptr));

// Then the remaining queues do blocking reads from the buffer. Since the
// queues target different devices this checks that any devices memory has
// been synchronized.
for (unsigned i = 1; i < queues.size(); ++i) {
const auto queue = queues[i];
std::vector<uint32_t> output(count, 0);
EXPECT_SUCCESS(urEnqueueMemBufferRead(queue, dst_buffer, true, 0, size,
ASSERT_SUCCESS(urEnqueueMemBufferRead(queue, dst_buffer, true, 0, size,
output.data(), 0, nullptr, nullptr));
for (unsigned j = 0; j < count; ++j) {
EXPECT_EQ(input, output[j])
<< "Result on queue " << i << " did not match at index " << j << "!";
}
}

EXPECT_SUCCESS(urMemRelease(dst_buffer));
ASSERT_SUCCESS(urMemRelease(dst_buffer));
}
6 changes: 3 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferReadRect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,13 @@ TEST_P(urEnqueueMemBufferReadRectTestWithParam, Success) {
// The input will just be sequentially increasing values.
std::vector<uint8_t> input(buffer_size, 0x0);
std::iota(std::begin(input), std::end(input), 0x0);
EXPECT_SUCCESS(urEnqueueMemBufferWrite(queue, buffer, /* isBlocking */ true,
ASSERT_SUCCESS(urEnqueueMemBufferWrite(queue, buffer, /* isBlocking */ true,
0, input.size(), input.data(), 0,
nullptr, nullptr));

// Enqueue the rectangular read.
std::vector<uint8_t> output(host_size, 0x0);
EXPECT_SUCCESS(urEnqueueMemBufferReadRect(
ASSERT_SUCCESS(urEnqueueMemBufferReadRect(
queue, buffer, /* isBlocking */ true, buffer_offset, host_offset, region,
buffer_row_pitch, buffer_slice_pitch, host_row_pitch, host_slice_pitch,
output.data(), 0, nullptr, nullptr));
Expand All @@ -119,7 +119,7 @@ TEST_P(urEnqueueMemBufferReadRectTestWithParam, Success) {
EXPECT_EQ(expected, output);

// Cleanup.
EXPECT_SUCCESS(urMemRelease(buffer));
ASSERT_SUCCESS(urMemRelease(buffer));
}

struct urEnqueueMemBufferReadRectTest : public uur::urMemBufferQueueTest {
Expand Down
6 changes: 3 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferWriteRect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ TEST_P(urEnqueueMemBufferWriteRectTestWithParam, Success) {
std::iota(std::begin(input), std::end(input), 0x0);

// Enqueue the rectangular write from that host buffer.
EXPECT_SUCCESS(urEnqueueMemBufferWriteRect(
ASSERT_SUCCESS(urEnqueueMemBufferWriteRect(
queue, buffer, /* isBlocking */ true, buffer_origin, host_origin, region,
buffer_row_pitch, buffer_slice_pitch, host_row_pitch, host_slice_pitch,
input.data(), 0, nullptr, nullptr));

std::vector<uint8_t> output(buffer_size, 0x0);
EXPECT_SUCCESS(urEnqueueMemBufferRead(queue, buffer, /* is_blocking */ true,
ASSERT_SUCCESS(urEnqueueMemBufferRead(queue, buffer, /* is_blocking */ true,
0, buffer_size, output.data(), 0,
nullptr, nullptr));

Expand All @@ -126,7 +126,7 @@ TEST_P(urEnqueueMemBufferWriteRectTestWithParam, Success) {
EXPECT_EQ(expected, output);

// Cleanup.
EXPECT_SUCCESS(urMemRelease(buffer));
ASSERT_SUCCESS(urMemRelease(buffer));
}

struct urEnqueueMemBufferWriteRectTest : public uur::urMemBufferQueueTest {
Expand Down
Loading