Skip to content

[CI][Benchmarks] Display all legend items in charts #19546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

PatKamin
Copy link
Contributor

Don't truncate legend, always display all legend items.

@PatKamin PatKamin requested a review from a team as a code owner July 22, 2025 11:45
Don't truncate legend, always display all legend items.
@pbalcer
Copy link
Contributor

pbalcer commented Jul 23, 2025

can you show a screenshot with the difference?

@PatKamin
Copy link
Contributor Author

can you show a screenshot with the difference?

See the truncation before the change. I've disabled most of series to show that more legend items are hidden below the chart:
image

Now all legend items are visible:
image

@pbalcer
Copy link
Contributor

pbalcer commented Jul 29, 2025

Makes sense, but the proper solution here is to make sure we don't have groups with dozens and dozens of series ;)

We need to refactor SubmitGraph to be grouped more like SubmitKernel.

@PatKamin
Copy link
Contributor Author

Makes sense, but the proper solution here is to make sure we don't have groups with dozens and dozens of series ;)

We need to refactor SubmitGraph to be grouped more like SubmitKernel.

There is also an old TODO in compute.py for this ;) I think this can be done in another PR.

@PatKamin
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge

@aelovikov-intel aelovikov-intel merged commit ea4d68c into intel:sycl Jul 29, 2025
40 of 41 checks passed
@PatKamin PatKamin deleted the full-legend branch July 29, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants