Skip to content

[SYCL] Fix adjusted kernel name handling in preview RT build #19582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sergey-semenov
Copy link
Contributor

@sergey-semenov sergey-semenov commented Jul 24, 2025

Remove usage of a temporary string where the program manager receives and stores a string view in the preview build.

Remove usage of a temporary string where the program manager receives
and stores a string view in the preview mode.
@cperkinsintel
Copy link
Contributor

I has a dumb question. What is a "preview build" or "preview mode" ?

@sergey-semenov
Copy link
Contributor Author

"Preview build" as in the preview breaking changes build of the SYCL RT library.

@sergey-semenov sergey-semenov changed the title [SYCL] Fix adjusted kernel name handling in preview builds [SYCL] Fix adjusted kernel name handling in preview RT build Jul 25, 2025
@sergey-semenov sergey-semenov marked this pull request as ready for review July 25, 2025 16:23
@sergey-semenov sergey-semenov requested a review from a team as a code owner July 25, 2025 16:23
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the failing test related? otherwise, LGTM.

@sergey-semenov
Copy link
Contributor Author

The failure appears unrelated and was recently observed on another PR: #15207

@sergey-semenov sergey-semenov merged commit 46296dc into intel:sycl Jul 30, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants