[CI] Detect changes to libdevice #19584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
This reverts commit 26c5c3f.
uditagarwal97
approved these changes
Jul 24, 2025
Comment on lines
57
to
58
| libdevice: &libdevice | ||
| - 'libdevice/**' |
There was a problem hiding this comment.
I think we need a comment explaining why this doesn't depend on anything.
There was a problem hiding this comment.
is that what * means? if so i should probably add llvm clang and sycl
There was a problem hiding this comment.
is that what * means?
Yes. I think it literally means something like "include"/copy, but for our purposes this is the representation of dependencies.
There was a problem hiding this comment.
But they also are inter-dependent, I think. So maybe a better fix would be to just add libdevice directory under sycl, and change the caller to use sycl for libdevice tests.
Signed-off-by: Sarnie, Nick <[email protected]>
aelovikov-intel
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check this in the windows/linux build workflows but we never set it, so use the existing
syclspecifier.Closes: #19573