[libclc] Let builtins_remangle_path generating command depend on prepare-${obj_suffix} target #19619
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are-${obj_suffix} target
The add_custom_command depends on builtins_lib, but not on
prepare-${obj_suffix} target that generates builtins_lib. cmake
documentation doesn't mention that the add_custom_command will
automatically depends on prepare-${obj_suffix} target.
The dependency was removed in f07c1fa. However, our downstream repo
reintroduced it to fix build error in CMPLRLLVM-57824, where builtins_lib is
used while still being generated.
This PR adds the dependency back. Then, cmake will create a target-level
dependency to make sure prepare-${obj_suffix} target is built before
target "remangled-${long_width}-${signedness}_char.${obj_suffix_mangled}".
frasercrmck
approved these changes
Jul 29, 2025
tcreech-intel
approved these changes
Jul 29, 2025
|
@intel/llvm-gatekeepers please merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add_custom_command depends on builtins_lib, but not on prepare-${obj_suffix} target that generates builtins_lib. cmake documentation doesn't mention that the add_custom_command will automatically depends on prepare-${obj_suffix} target.
The dependency was removed in f07c1fa. However, our downstream repo reintroduced it to fix build error in CMPLRLLVM-57824, where builtins_lib is used while still being generated.
This PR adds the dependency back. Then, cmake will create a target-level dependency to make sure prepare-${obj_suffix} target is built before target "remangled-${long_width}-${signedness}_char.${obj_suffix_mangled}".