[SYCL] Add flag to print CMake args without execution to buildbot.py #19636
Conversation
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@KornevNikita This is a follow up from the discussion in issue #19347, they're working on NixOS packaging and the raw CMake commands is useful to them |
| @@ -411,9 +416,13 @@ def main(): | |||
| parser.add_argument( | |||
| "--use-zstd", action="store_true", help="Force zstd linkage while building." | |||
| ) | |||
| parser.add_argument( | |||
There was a problem hiding this comment.
maybe we could call the flag --dry-run? that one is commonly used and seems to fit here
There was a problem hiding this comment.
Line 140 would be a less obvious change with dry-run as option name. Not that I'm arguing for one or another, just stating.
There was a problem hiding this comment.
ah yeah fair, based on the description it seems generating a cmake command with no other output is important for this use case, so the name is fine enough as is and i don't think we need to spend 15 years bikeshedding :)
There was a problem hiding this comment.
Just to make it clear, we still reserve the right to remove the entire script if we switch to using CMake caches instead of it. Use it in any automation at your own risk.
There was a problem hiding this comment.
Right sorry, I mentioned it in the issue I linked in my other comment but this script is for the convenience of developers in the repo, and the only stable interface is the LLVM CMake infrastructure which we have extended.
There was a problem hiding this comment.
Yeah that was my reasoning behind not naming it --dry-run as well.
I understand that the script isn't stable, I'm just using it because it's the method recommended by the docs and makes it easier to keep in sync. (It's also what the AUR packages uses for example)
The way updates on Nix work, any update will require manual approval anyways, so there shouldn't be any random breakage if it gets removed.
Adds a `--print-cmake-flags` option to the configure.py helper script. When used, the script will print the generated list of CMake arguments to stdout and exit immediately. This suppresses all other output and does not invoke the cmake command. This is useful for packaging or integrating with build systems that need/prefer to call cmake manually.
|
Rebased to fix formatting errors |
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
blenderfreaky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Adds a
--print-cmake-flagsoption to the configure.py helper script.When used, the script will print the generated list of CMake arguments to stdout and exit immediately. This suppresses all other output and does not invoke the cmake command.
This is useful for packaging or integrating with build systems that need/prefer to call cmake manually.
Tagging @sarnex