[CI] Control each kind of pre-built E2E tests by its own input #19645
Conversation
Also changed default install directory to avoid ugly copy.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -58,7 +58,9 @@ jobs: | |||
| changes: ${{ needs.detect_changes.outputs.filters }} | |||
|
|
|||
| toolchain_artifact: sycl_linux_default | |||
| e2e_binaries_artifact: sycl_e2e_bin_default | |||
| e2e_binaries_artifact: e2e_bin | |||
There was a problem hiding this comment.
again not really related but i wonder if we really need to expose as inputs to sycl-linux-build, could we just require they are e2e_bin{_spirv_backend, _preview}? i don't expect these will ever be used by anyone outside of CI testing so the name shouldnt matter to anyone
There was a problem hiding this comment.
What I'm trying to do is to allow specifying only some kinds of e2e tests vs all-or-nothing (I'm not interested in preview mode when creating a container image for the compatibility testing).
It doesn't make much difference between three bools with default names vs three explicit names. However, we do need to pass the names later on to sycl-linux-run-tests.yml and it's easier if the names are defined here vs defaulted inside the sycl-linux-build.yml workflow.
There was a problem hiding this comment.
I can also think of possibly having two toolchain builds (e.g. libstdc++ and libcxx) in a single task (e.g. Nightly/Weekly). We'd need to separate e2e tests built with either toolchain, so having this name would be handy.
| - name: Preview Mode | ||
| runner: '["Linux", "gen12"]' | ||
| image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN | ||
| target_devices: level_zero:gpu;opencl:gpu;opencl:cpu | ||
| extra_lit_opts: --param test-preview-mode=True | ||
| e2e_binaries_artifact: sycl_e2e_bin_default_preview | ||
| e2e_binaries_artifact: e2e_bin_preview |
There was a problem hiding this comment.
kinda of a nit maybe but i wonder if we could single-source these names by making it an output of the build step one something or some workflow global var or something
There was a problem hiding this comment.
I don't see a good way to do that... The fact that we have any tests built in the sycl-*-build.yml is kind of a hack to improve CI performance as we avoid extra job/upload/download by building the tests in the same job/on the same runner. That hack in itself is causing this weirdness.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
is covered by #15207. |
Also changed default install directory to avoid ugly copy.