[UR][CMake] Improve handling of UMF and hdr_histogram #19705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
pbalcer
approved these changes
Aug 6, 2025
Signed-off-by: Sarnie, Nick <[email protected]>
igchor
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, add support for pre-installed
hdr_histogram.Second, make
UR_USE_EXTERNAL_UMFon by default and have it fallback toFetchContentif it is not found instead of erroring. The user can disable it to forceFetchContenteven if they have a preinstalled version.We don't need repo or tag variables because the user can just set
FETCHCONTENT_SOURCE_DIR_UNIFIED-MEMORY-FRAMEWORK, and this matches how we handle other deps.Issue: #19635