[SYCL][NATIVECPU] Fix TargetInfo initialization (DataLayoutString) #19711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedolinsky
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
coldav
approved these changes
Aug 5, 2025
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
approved these changes
Aug 5, 2025
|
@intel/llvm-gatekeepers This looks ready to merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clang targets (for example for Arm) may not initialize
DataLayoutStringin their TargetInfo constructor, which meant callsgetDataLayoutStringright after the constructor cause an assert.This PR defers the initialization of the NativeCPU TargetInfo to after the call of
handleTargetFeaturesof the host cpu Target info, which on Arm initializesDataLayoutString, but may also catch more initializations.