[SYCL][E2E] Better control of testing preview-mode
#19735
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the PR we had two modes: * Default, auto-detect preview support in toolchain and have individual tests run dedicated `RUN`-lines * `--param test-preview-mode=<anything but False>`, run entire suite in preview mode using non-preview `RUN`-lines. Special `RUN`-lines dedicated to preview are ignored. This PR changes it to this: * Only allow `test-preview-mode` to be unset or set to True/False, fatal error on any other value. * If True/unset behave as in two previous scenarios * If False, only execute `RUN`-lines without preview markup I need this for compatibility testing because preview mode isn't backward ABI-compatible and I'm going to cherry-pick this to `sycl-rel-6_[23]` For trunk, I think we should just remove special `RUN`-lines and rely on "full preview" mode job in CI, but that will be a separate PR (because I wouldn't be able to backport such a big change). Cherry-picks #19727
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Aug 6, 2025
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR we had two modes:
RUN-lines--param test-preview-mode=<anything but False>, run entire suite in preview mode using non-previewRUN-lines. SpecialRUN-lines dedicated to preview are ignored.This PR changes it to this:
test-preview-modeto be unset or set to True/False, fatal error on any other value.RUN-lines without preview markupI need this for compatibility testing because preview mode isn't backward ABI-compatible and I'm going to cherry-pick this to
sycl-rel-6_[23]For trunk, I think we should just remove special
RUN-lines and rely on "full preview" mode job in CI, but that will be a separate PR (because I wouldn't be able to backport such a big change).Cherry-picks #19727