Skip to content

[CI] Cleanup E2E matrix codes #19741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2025
Merged

[CI] Cleanup E2E matrix codes #19741

merged 3 commits into from
Aug 7, 2025

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Aug 7, 2025 •
edited
Loading

  • Add default value for image_options
  • Drop unused matrix-xmx8
  • Don't set gpu-intel-gen12, rely on auto-detection in

    llvm/sycl/test-e2e/lit.cfg.py

    Lines 240 to 256 in dc8068f

    # Map between device family and architecture types.
    device_family_arch_map = {
    # <Family name> : Set of architectures types (and aliases)
    # DG2
    "gpu-intel-dg2": {
    "intel_gpu_acm_g12",
    "intel_gpu_dg2_g12",
    "intel_gpu_acm_g11",
    "intel_gpu_dg2_g11",
    "intel_gpu_acm_g10",
    "intel_gpu_dg2_g10",
    },
    # Gen12
    "gpu-intel-gen12": {"intel_gpu_tgllp", "intel_gpu_tgl"},
    # Gen11
    "gpu-intel-gen11": {"intel_gpu_icllp", "intel_gpu_icl"},
    }
  • Align naming of the individual matrix jobs

@aelovikov-intel
[CI] Cleanup precommit E2E matrix code
a0c312e 
* Add default value for `image_options`
* Drop unused `matrix-xmx8`
* Don't set `gpu-intel-gen12`, rely on auto-detection in
  https://github.com/intel/llvm/blob/dc8068fe687b24a0f8018ea6c43fc4f9183f9bb7/sycl/test-e2e/lit.cfg.py#L240-L256
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner August 7, 2025 16:22
sarnex
sarnex approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Could be in a follow-up PR but seems matrix-xmx8=True is set in postcommit too

@aelovikov-intel aelovikov-intel changed the title [CI] Cleanup precommit E2E matrix code [CI] Cleanup E2E matrix codes Aug 7, 2025
@aelovikov-intel
Copy link
Contributor Author

Nice!

Could be in a follow-up PR but seems matrix-xmx8=True is set in postcommit too

Done for both post-commit and nightly.

KornevNikita
KornevNikita reviewed Aug 7, 2025
View reviewed changes
@aelovikov-intel aelovikov-intel mentioned this pull request Aug 7, 2025
Merged
@aelovikov-intel aelovikov-intel merged commit 3b05692 into intel:sycl Aug 7, 2025
34 of 35 checks passed
@aelovikov-intel aelovikov-intel deleted the cleanup-precommit-matrix branch August 7, 2025 17:59
ggojska pushed a commit to ggojska/llvm that referenced this pull request Aug 12, 2025
@aelovikov-intel @ggojska
[CI] Cleanup E2E matrix codes (intel#19741)
67dc3ba 
* Add default value for `image_options`
* Drop unused `matrix-xmx8`
* Don't set `gpu-intel-gen12`, rely on auto-detection in
https://github.com/intel/llvm/blob/dc8068fe687b24a0f8018ea6c43fc4f9183f9bb7/sycl/test-e2e/lit.cfg.py#L240-L256
* Align naming of the individual matrix jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KornevNikita KornevNikita KornevNikita left review comments

@sarnex sarnex sarnex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @sarnex @KornevNikita