[CI] Change codeowners for backward ABI-compatibility exclude lists #19820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#19719 and intel#19761 added pre-commit jobs to run E2E tests pre-built with latest "open-source" releases against the newly built sycl-toolchain libraries. Those can fail if either an actual break is happenning or if the test was doing some `FileCheck`ing and that output has changed in some way (which might not be an actual ABI break). However, I think the testing is still good enough to require an explicit approvals by folks in charge of ABI breaking changes. For the case of just output change the author should be able to convince owners that the change isn't ABI-breaking relatively easily.
gmlueck
approved these changes
Aug 18, 2025
uditagarwal97
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19719 and
#19761 added pre-commit jobs to run E2E tests pre-built with latest "open-source" releases against the newly built sycl-toolchain libraries. Those can fail if either an actual break is happenning or if the test was doing some
FileChecking and that output has changed in some way (which might not be an actual ABI break).However, I think the testing is still good enough to require an explicit approvals by folks in charge of ABI breaking changes. For the case of just output change the author should be able to convince owners that the change isn't ABI-breaking relatively easily.