-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make QueryCarousels Edition Aware #10472
base: master
Are you sure you want to change the base?
Make QueryCarousels Edition Aware #10472
Conversation
This makes more sense for browse-ish carousels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10472 +/- ##
==========================================
- Coverage 17.31% 17.27% -0.04%
==========================================
Files 87 87
Lines 4835 4845 +10
Branches 856 860 +4
==========================================
Hits 837 837
- Misses 3471 3477 +6
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. |
702a924
to
be9f271
Compare
a191464
to
b38a1a4
Compare
for more information, see https://pre-commit.ci
So, this mostly works so far. I'm still ironing out a few kinks. I've stopped it from breaking the current macro, but haven't yet figured out why the addition of 'lang' causes problems. Also, it doesn't yet show editions, which is a problem. |
…ibraryfork into edition-aware-carousels
This reverts commit e1e5c1e.
Alright, everything should be good to go here. The commit history is slightly messy, but nothing that should cause a problem. It's been tested on my end, and works fine. |
Closes #7252
As of this moment, carousels link to and display works, rather than specific editions. This prevents users from specifically locating given editions of works on carousels, which is not ideal. This PR alters the functionality of carousels to link to and show covers of editions rather than works.
Technical
This issue originally called for restricting the editions that show to ones matching the user's language. In the name of getting this feature out sooner, that has been left out on Drini's advice, to be achieved in a later PR.
Testing
Create a new page on your local version, and create a Carousel macro.
{{QueryCarousel("*")}}
should be a functional command.Screenshot
And when clicked:
Stakeholders
@jimchamp