-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to use the new JPMS model and use Travis-ci to build & test against Java 9 & 11 #28
Conversation
- Use of the new JPMS system (since Java 9) - Update of Classloader to match Java 9+ Classloader mechanism.
Hey, thanks for the PR 🍰 |
Removal of definitely (wrong) whitespace characters.
Here you are, sorry for that, my IDE is introducing those, I must check why. |
check here: https://github.com/inwc3/JMPQ3/pull/28/files#diff-59152c8afada68aad461481629115b78 Since there are only few changes, might be easier to revert completely. |
Removing whitespace characters for try - catch statements.
Updated as well. |
It obviously fails on oracle 8 and 9... Since I compiled on 11. I may lower this to jdk 9 but as the JPMS didn't exist in jdk8, it's a breaking point. Which trade-off would you prefer? I'll keep working with the modularized version anyway and will keep syncing your commits on my repo. |
Probably just keep on a branch and merge when we move all projects to 11+ |
Good idea, I'll do that and do a proper commit + PR request again. |
Alright, I created a java9-module branch https://github.com/inwc3/JMPQ3/tree/java9-module |
Hi,
This is in reaction to the following issue: #27