Skip to content

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Jul 16, 2020

Added ARM64 jobs in Travis-CI.

Resolves #43.

@odidev odidev force-pushed the odidev-arm64 branch 2 times, most recently from 0d5c22e to 1dad85d Compare July 17, 2020 05:46
@odidev
Copy link
Contributor Author

odidev commented Jul 17, 2020

@ionelmc ,

AMD64 and ARM64 no-cov jobs have been failed with timeout error as it is not able to get twine password and OSX python 3.7 jobs are failing with python interpreter issue, as in command brew upgrade python, python is being upgraded to version 3.8.4.

Please review and let me know if any changes required.

.travis.yml Outdated
python: 'pypy3'
before_install:
- if [[ ${TRAVIS_CPU_ARCH} != "arm64" ]]; then
export LD_PRELOAD=/lib/x86_64-linux-gnu/libSegFault.so;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this maybe be /lib/aarch64-linux-gnu/libSegFault.so? Is there a way to verify that (eg, you have a arm64 machine around)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked in my local machine and added as suggested. Please review and let me know if anymore changes required.

.travis.yml Outdated
after_failure:
- more .tox/log/* | cat
- more .tox/*/log/* | cat
- travis_wait 15 more .tox/log/* | cat
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of using the waiter here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the build fails in arm64, this command was giving timeout error when tested locally. After adding this code, command is executing properly.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest now I wonder why I didn't have just cat .tox/log/* directly in there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated that command to cat .tox/log/*.

@ionelmc
Copy link
Owner

ionelmc commented Jul 17, 2020

So I've added some questions. No worries about the CI failures (there some stuff there that I need to fix for osx anyway).

@odidev odidev force-pushed the odidev-arm64 branch 2 times, most recently from 2ef38d3 to c69b208 Compare July 17, 2020 14:37
@odidev
Copy link
Contributor Author

odidev commented Jul 17, 2020

After adding c69b208 , travis build has been triggered in odidev travis account.

Report link: https://travis-ci.org/github/odidev/python-lazy-object-proxy/builds/709207016

I am not sure why travis build has not been triggered here.

@odidev
Copy link
Contributor Author

odidev commented Jul 20, 2020

@ionelmc ,

Thanks for adding the commits. May I know, When are you planning to make a release with aarch64 wheels to PyPI?

@ionelmc
Copy link
Owner

ionelmc commented Jul 20, 2020

Seems that github didn't detect the rebase.

About releasing ... I guess today? I would like to know why the wheels are manylinux2014 instead of manylinux1. You can take a look and try the latest produced wheels here: https://test.pypi.org/project/lazy-object-proxy/1.5.1.dev5/#files

@ionelmc ionelmc closed this Jul 20, 2020
@odidev
Copy link
Contributor Author

odidev commented Jul 20, 2020

Seems that github didn't detect the rebase.

About releasing ... I guess today? I would like to know why the wheels are manylinux2014 instead of manylinux1. You can take a look and try the latest produced wheels here: https://test.pypi.org/project/lazy-object-proxy/1.5.1.dev5/#files

Thanks for the reply. I am able to successfully install from the wheels available in test-PyPI. Pypa manylinux has added aarch64 support only for manylinux2014 not for manylinux1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheel support for linux aarch64
2 participants