-
-
Notifications
You must be signed in to change notification settings - Fork 37
Add ARM64 jobs in Travis-CI #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d5c22e
to
1dad85d
Compare
@ionelmc , AMD64 and ARM64 Please review and let me know if any changes required. |
.travis.yml
Outdated
python: 'pypy3' | ||
before_install: | ||
- if [[ ${TRAVIS_CPU_ARCH} != "arm64" ]]; then | ||
export LD_PRELOAD=/lib/x86_64-linux-gnu/libSegFault.so; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this maybe be /lib/aarch64-linux-gnu/libSegFault.so
? Is there a way to verify that (eg, you have a arm64 machine around)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked in my local machine and added as suggested. Please review and let me know if anymore changes required.
.travis.yml
Outdated
after_failure: | ||
- more .tox/log/* | cat | ||
- more .tox/*/log/* | cat | ||
- travis_wait 15 more .tox/log/* | cat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of using the waiter here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the build fails in arm64, this command was giving timeout error when tested locally. After adding this code, command is executing properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest now I wonder why I didn't have just cat .tox/log/*
directly in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated that command to cat .tox/log/*
.
So I've added some questions. No worries about the CI failures (there some stuff there that I need to fix for osx anyway). |
2ef38d3
to
c69b208
Compare
After adding c69b208 , travis build has been triggered in odidev travis account. Report link: https://travis-ci.org/github/odidev/python-lazy-object-proxy/builds/709207016 I am not sure why travis build has not been triggered here. |
@ionelmc , Thanks for adding the commits. May I know, When are you planning to make a release with aarch64 wheels to PyPI? |
Seems that github didn't detect the rebase. About releasing ... I guess today? I would like to know why the wheels are manylinux2014 instead of manylinux1. You can take a look and try the latest produced wheels here: https://test.pypi.org/project/lazy-object-proxy/1.5.1.dev5/#files |
Thanks for the reply. I am able to successfully install from the wheels available in test-PyPI. Pypa manylinux has added aarch64 support only for manylinux2014 not for manylinux1. |
Added ARM64 jobs in Travis-CI.
Resolves #43.